Skip to content

Conversation

@glemaitre
Copy link
Member

@glemaitre glemaitre commented Mar 26, 2017

Reference Issue

Fixes #253

What does this implement/fix? Explain your changes.

There is no User Guide for the moment. We have to add some with explanations of the different methods.

TODO:

  • Add sphinx gallery examples
  • Add buttoncopy js

Any other comments?

glemaitre and others added 3 commits May 19, 2017 22:37
* change cleaning-sampler to clean-sampler * Refactor the over_sampling * [WIP] adapt ensamble class
* change cleaning-sampler to clean-sampler * Refactor the over_sampling * [WIP] adapt ensamble class * iterate * fix PEP8
@pep8speaks
Copy link

pep8speaks commented May 24, 2017

Hello @glemaitre! Thanks for updating the PR.

  • In the file doc/conf.py, following are the PEP8 issues :

Line 30:1: E722 do not use bare except'
Line 41:1: E402 module level import not at top of file
Line 309:80: E501 line too long (86 > 79 characters)
Line 336:80: E501 line too long (84 > 79 characters)

Comment last updated on June 15, 2017 at 18:40 Hours UTC
@glemaitre
Copy link
Member Author

@chkoar
Copy link
Member

chkoar commented May 25, 2017

@glemaitre very nice

glemaitre and others added 15 commits May 30, 2017 17:56
* EHN enable multiclass ratio handling * FIX simplify call to dictionary * FIX RUS done * FIX Refactor ADASYN * FIX partial * FIX refactor SMOTE * FIX refactor SMOTE * DOC add proper docstring * PEP8 * FIX ClusterCentroids * FIX refactor IHT * FIX Nearmiss refactoring * FIX tomek links refactor * FIX refactor OSS * FIX NCR refactoring * FIX refactor combined methods with Pipeline * FIX combine method targetting all classes when cleaning * FIX balance cascade refactoring * EHN add the possibility to add a dict for ratio * TST add test for check_ratio * TST add test for float * FIX/TST adapt common test * TST fix IHT tests * TST fix NCR * FIX combine test * TST fix balance * FIX doctest * FIX doctest * FIX solve the pickle issue * FIX remove comments * TST add test for NCR * TST add knn balance cascade * EHN add callable option for the ratio * DOC make doc cleaner * FIX/DOC remove useless comments and clean doc * DEP deprecation of ratio as float * EHN add base class for cleaning methods * TST add common test for multi class * MAINT downgrade sphinx for the moment * TST/EHN add test for the ratio and specific ratio for cleaning sampling * EHN remove redundant code * FIX warning * Remove useless base class * MAINT add christos back to some file * EHN rename test and add a comment * DOC add hash_X_y in the API * [MRG] Incorporate chkoar remarks (#6) * change cleaning-sampler to clean-sampler * Refactor the over_sampling * [WIP] adapt ensamble class * [MRG] Remove the init in base class (#7) * change cleaning-sampler to clean-sampler * Refactor the over_sampling * [WIP] adapt ensamble class * iterate * fix PEP8 * EHN doc * FIX add extension for sphinx * EHN make deprecatin great again * EHN Improve SMOTE and ADASYN
@glemaitre glemaitre force-pushed the master branch 2 times, most recently from ab8214b to 19617eb Compare June 15, 2017 19:14
@glemaitre glemaitre closed this Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet