Skip to content

Conversation

@glemaitre
Copy link
Member

Reference Issue

Fixes #251

What does this implement/fix? Explain your changes.

Should make link clickable in the doc.

Any other comments?

@pep8speaks
Copy link

pep8speaks commented Mar 20, 2017

Hello @glemaitre! Thanks for updating the PR.

  • In the file doc/conf.py, following are the PEP8 issues :

Line 23:1: E265 block comment should start with '# '
Line 35:1: E265 block comment should start with '# '
Line 77:1: E265 block comment should start with '# '
Line 101:1: E265 block comment should start with '# '
Line 105:1: E265 block comment should start with '# '
Line 107:1: E265 block comment should start with '# '
Line 115:1: E265 block comment should start with '# '
Line 122:1: E265 block comment should start with '# '
Line 126:1: E265 block comment should start with '# '
Line 132:1: E265 block comment should start with '# '
Line 135:1: E265 block comment should start with '# '
Line 146:1: E265 block comment should start with '# '
Line 153:1: E265 block comment should start with '# '
Line 156:1: E265 block comment should start with '# '
Line 160:1: E265 block comment should start with '# '
Line 165:1: E265 block comment should start with '# '
Line 175:1: E265 block comment should start with '# '
Line 179:1: E265 block comment should start with '# '
Line 183:1: E265 block comment should start with '# '
Line 186:1: E265 block comment should start with '# '
Line 190:1: E265 block comment should start with '# '
Line 193:1: E265 block comment should start with '# '
Line 196:1: E265 block comment should start with '# '
Line 199:1: E265 block comment should start with '# '
Line 202:1: E265 block comment should start with '# '
Line 205:1: E265 block comment should start with '# '
Line 208:1: E265 block comment should start with '# '
Line 213:1: E265 block comment should start with '# '
Line 216:1: E265 block comment should start with '# '
Line 225:5: E265 block comment should start with '# '
Line 228:5: E265 block comment should start with '# '
Line 231:5: E265 block comment should start with '# '
Line 244:1: E265 block comment should start with '# '
Line 248:1: E265 block comment should start with '# '
Line 251:1: E265 block comment should start with '# '
Line 254:1: E265 block comment should start with '# '
Line 257:1: E265 block comment should start with '# '
Line 260:1: E265 block comment should start with '# '
Line 270:1: E265 block comment should start with '# '
Line 299:1: E265 block comment should start with '# '
Line 302:1: E265 block comment should start with '# '
Line 305:1: E265 block comment should start with '# '
Line 308:1: E265 block comment should start with '# '

Comment last updated on March 20, 2017 at 08:10 Hours UTC
@codecov
Copy link

codecov bot commented Mar 20, 2017

Codecov Report

Merging #254 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #254 +/- ## ======================================= Coverage 98.27% 98.27% ======================================= Files 58 58 Lines 3429 3429 ======================================= Hits 3370 3370 Misses 59 59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee7fcb3...8a13832. Read the comment docs.

@glemaitre glemaitre changed the title [WIP] FIX/DOC make link clickable [MRG] FIX/DOC make link clickable Mar 20, 2017
@glemaitre glemaitre merged commit 13f4e8a into scikit-learn-contrib:master Mar 20, 2017
@amueller
Copy link
Member

amueller commented Mar 20, 2017

the sklearn link looks wrong, I think. Should at point to dev or stable, I think.

@amueller
Copy link
Member

also thanks for being so responsive :)

@glemaitre
Copy link
Member Author

Ups.

I got some vacation, so I have a bit of time solving whatever I could not in the last months ;)

christophe-rannou pushed a commit to christophe-rannou/imbalanced-learn that referenced this pull request Apr 3, 2017
* FIX/DOC make link clickable * PEP8/FIX
glemaitre added a commit to glemaitre/imbalanced-learn that referenced this pull request Jun 15, 2017
* FIX/DOC make link clickable * PEP8/FIX
glemaitre added a commit to glemaitre/imbalanced-learn that referenced this pull request Jun 15, 2017
* FIX/DOC make link clickable * PEP8/FIX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants