[MRG] Tests refactoring #242

glemaitre · 2017-03-13T09:54:20Z

Reference Issue

Fixes #238

What does this implement/fix? Explain your changes.

TODO:

Remove useless doctring from the tests;
Remove useless comments;
Create a test_common.py for the different samplers:
- check_estimator;
- Is BinarySampler or MulticlassSampler;
- test ratio;
- test single class;
- test check_fitting -> we need to bring check_is_fit from sklearn;
- test sampling wrong X.

Any other comments?

pep8speaks · 2017-03-13T09:54:22Z

Hello @glemaitre! Thanks for updating the PR.

There are no PEP8 issues in the file imblearn/__init__.py !
There are no PEP8 issues in the file imblearn/base.py !
There are no PEP8 issues in the file imblearn/combine/smote_enn.py !
There are no PEP8 issues in the file imblearn/combine/smote_tomek.py !
There are no PEP8 issues in the file imblearn/combine/tests/test_smote_enn.py !
There are no PEP8 issues in the file imblearn/combine/tests/test_smote_tomek.py !
There are no PEP8 issues in the file imblearn/datasets/imbalance.py !
There are no PEP8 issues in the file imblearn/datasets/tests/test_make_imbalance.py !
There are no PEP8 issues in the file imblearn/ensemble/balance_cascade.py !
There are no PEP8 issues in the file imblearn/ensemble/tests/test_balance_cascade.py !
There are no PEP8 issues in the file imblearn/ensemble/tests/test_easy_ensemble.py !
There are no PEP8 issues in the file imblearn/exceptions.py !
There are no PEP8 issues in the file imblearn/metrics/tests/test_classification.py !
There are no PEP8 issues in the file imblearn/metrics/tests/test_score_objects.py !
There are no PEP8 issues in the file imblearn/over_sampling/adasyn.py !
There are no PEP8 issues in the file imblearn/over_sampling/smote.py !
There are no PEP8 issues in the file imblearn/over_sampling/tests/test_adasyn.py !
There are no PEP8 issues in the file imblearn/over_sampling/tests/test_random_over_sampler.py !
There are no PEP8 issues in the file imblearn/over_sampling/tests/test_smote.py !
There are no PEP8 issues in the file imblearn/setup.py !
There are no PEP8 issues in the file imblearn/tests/test_common.py !
There are no PEP8 issues in the file imblearn/tests/test_exceptions.py !
There are no PEP8 issues in the file imblearn/under_sampling/cluster_centroids.py !
There are no PEP8 issues in the file imblearn/under_sampling/condensed_nearest_neighbour.py !
There are no PEP8 issues in the file imblearn/under_sampling/edited_nearest_neighbours.py !
There are no PEP8 issues in the file imblearn/under_sampling/instance_hardness_threshold.py !
There are no PEP8 issues in the file imblearn/under_sampling/nearmiss.py !
There are no PEP8 issues in the file imblearn/under_sampling/neighbourhood_cleaning_rule.py !
There are no PEP8 issues in the file imblearn/under_sampling/one_sided_selection.py !
There are no PEP8 issues in the file imblearn/under_sampling/tests/test_allknn.py !
There are no PEP8 issues in the file imblearn/under_sampling/tests/test_cluster_centroids.py !
There are no PEP8 issues in the file imblearn/under_sampling/tests/test_condensed_nearest_neighbour.py !
There are no PEP8 issues in the file imblearn/under_sampling/tests/test_edited_nearest_neighbours.py !
There are no PEP8 issues in the file imblearn/under_sampling/tests/test_instance_hardness_threshold.py !
There are no PEP8 issues in the file imblearn/under_sampling/tests/test_nearmiss.py !
There are no PEP8 issues in the file imblearn/under_sampling/tests/test_neighbourhood_cleaning_rule.py !
There are no PEP8 issues in the file imblearn/under_sampling/tests/test_one_sided_selection.py !
There are no PEP8 issues in the file imblearn/under_sampling/tests/test_random_under_sampler.py !
There are no PEP8 issues in the file imblearn/under_sampling/tests/test_repeated_edited_nearest_neighbours.py !
There are no PEP8 issues in the file imblearn/under_sampling/tests/test_tomek_links.py !
There are no PEP8 issues in the file imblearn/utils/__init__.py !
There are no PEP8 issues in the file imblearn/utils/estimator_checks.py !
There are no PEP8 issues in the file imblearn/utils/testing.py !
There are no PEP8 issues in the file imblearn/utils/tests/test_estimator_checks.py !
There are no PEP8 issues in the file imblearn/utils/tests/test_testing.py !
There are no PEP8 issues in the file imblearn/utils/tests/test_validation.py !
There are no PEP8 issues in the file imblearn/utils/validation.py !

Comment last updated on March 17, 2017 at 20:16 Hours UTC

codecov · 2017-03-13T10:04:21Z

Codecov Report

Merging #242 into master will decrease coverage by 0.67%.
The diff coverage is 96.13%.

@@ Coverage Diff @@ ## master #242 +/- ## ========================================== - Coverage 98.95% 98.27% -0.68%  ========================================== Files 50 58 +8 Lines 4007 3429 -578 ========================================== - Hits 3965 3370 -595  - Misses 42 59 +17

Impacted Files	Coverage Δ
imblearn/under_sampling/tests/test_allknn.py	`100% <ø> (ø)`	⬆️
imblearn/__init__.py	`100% <ø> (ø)`	⬆️
...earn/under_sampling/condensed_nearest_neighbour.py	`100% <100%> (ø)`	⬆️
imblearn/over_sampling/smote.py	`93.6% <100%> (-0.43%)`	⬇️
imblearn/exceptions.py	`100% <100%> (ø)`
...n/under_sampling/tests/test_one_sided_selection.py	`100% <100%> (ø)`	⬆️
imblearn/under_sampling/tests/test_nearmiss.py	`100% <100%> (ø)`
...sampling/tests/test_neighbourhood_cleaning_rule.py	`100% <100%> (ø)`	⬆️
imblearn/ensemble/tests/test_easy_ensemble.py	`100% <100%> (ø)`	⬆️
imblearn/under_sampling/nearmiss.py	`97.64% <100%> (+2.04%)`	⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768def7...590d600. Read the comment docs.

glemaitre · 2017-03-17T01:24:34Z

@chkoar You were right the refactoring was worth when checking at the number of lines suppressed.
I manage also to solve some issue on the path that I did not figure out earlier. Now we through an error when there is only one class which make much more sense.

It is good for merging

glemaitre · 2017-03-17T02:14:34Z

You can check codecov but I don't think that the difference of coverage is a problem. This is difficult to cover the tools used for testing ;)
They are coming from sklearn so there so case that we are not using for the moment. I am not sure this is a good idea to remove those parts

glemaitre · 2017-03-17T20:30:56Z

@chkoar I think that this is good for merging this time

chkoar · 2017-03-19T15:06:44Z

Thanks

Remove useless docstring in tests Add utils and common test to check estimator Add test for meta-classifiers Factorize tests Add SkipTest from scikit-learn Add missing tests Remove useless tests

glemaitre changed the title ~~[WIP] Tests refactoring~~ [MRG] Tests refactoring Mar 17, 2017

glemaitre changed the title ~~[MRG] Tests refactoring~~ [WIP] Tests refactoring Mar 17, 2017

Guillaume Lemaitre added 8 commits March 17, 2017 02:22

TST Remove useless docstring in tests

0784ef4

TST remove useless docstring

cbef9ac

TST/EHN add utils and common test to check estimator

b82211c

TST add test for meta-classifiers

e7c2375

TST/FIX factorize tests

cb553df

TST/FIX remove fogotten tests

bebccc8

FIX add SkipTest from scikit-learn

67361fc

DOC Add whats new info and update doc

271d4cf

glemaitre force-pushed the fix_tests branch from fe97485 to 271d4cf Compare March 17, 2017 01:22

glemaitre changed the title ~~[WIP] Tests refactoring~~ [MRG] Tests refactoring Mar 17, 2017

Guillaume Lemaitre added 2 commits March 17, 2017 14:45

TST add missing tests

6dabe31

TST remove useless tests

c7428c4

glemaitre changed the title ~~[MRG] Tests refactoring~~ [WIP] Tests refactoring Mar 17, 2017

Guillaume Lemaitre added 4 commits March 17, 2017 18:31

TST/EHN improve msg raised and test checking

50ac702

FIX fix tests

2e614c3

TST/EHN factorize NN tests

d6ad9a8

PEP8/DOC/TST final touch

590d600

glemaitre changed the title ~~[WIP] Tests refactoring~~ [MRG] Tests refactoring Mar 17, 2017

glemaitre mentioned this pull request Mar 17, 2017

Highlight only errors pep8speaks-org/pep8speaks#25

Closed

glemaitre mentioned this pull request Mar 18, 2017

[MRG] EHN add collections of imbalanced datasets #249

Merged

3 tasks

chkoar merged commit ee7fcb3 into scikit-learn-contrib:master Mar 19, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MRG] Tests refactoring #242

[MRG] Tests refactoring #242

Uh oh!

glemaitre commented Mar 13, 2017 •

edited

Loading

pep8speaks commented Mar 13, 2017 •

edited

Loading

codecov bot commented Mar 13, 2017 •

edited

Loading

glemaitre commented Mar 17, 2017

glemaitre commented Mar 17, 2017

glemaitre commented Mar 17, 2017

chkoar commented Mar 19, 2017

Labels

3 participants

[MRG] Tests refactoring #242

[MRG] Tests refactoring #242

Uh oh!

Conversation

glemaitre commented Mar 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reference Issue

What does this implement/fix? Explain your changes.

Any other comments?

pep8speaks commented Mar 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated on March 17, 2017 at 20:16 Hours UTC

codecov bot commented Mar 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

glemaitre commented Mar 17, 2017

glemaitre commented Mar 17, 2017

glemaitre commented Mar 17, 2017

chkoar commented Mar 19, 2017

Labels

3 participants

glemaitre commented Mar 13, 2017 •

edited

Loading

pep8speaks commented Mar 13, 2017 •

edited

Loading

codecov bot commented Mar 13, 2017 •

edited

Loading