Skip to content

[MRG] ENH: Remove **kwargs #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chkoar merged 6 commits into from
Dec 3, 2016
Merged

[MRG] ENH: Remove **kwargs #190

chkoar merged 6 commits into from
Dec 3, 2016

Conversation

@glemaitre
Copy link
Member

@glemaitre glemaitre commented Nov 3, 2016

Address issue #168
@coveralls
Copy link

coveralls commented Nov 3, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 98.785% when pulling 58882e2 on glemaitre:remove_kwargs into a1af197 on scikit-learn-contrib:master.
@coveralls
Copy link

coveralls commented Nov 3, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 98.765% when pulling 9fcbbac on glemaitre:remove_kwargs into a1af197 on scikit-learn-contrib:master.
@coveralls
Copy link

coveralls commented Nov 3, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 98.745% when pulling 23491da on glemaitre:remove_kwargs into a1af197 on scikit-learn-contrib:master.
@coveralls
Copy link

coveralls commented Nov 3, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 98.803% when pulling 6d94ef7 on glemaitre:remove_kwargs into a1af197 on scikit-learn-contrib:master.
@glemaitre glemaitre changed the title ENH: Remove **kwargs [MRG] ENH: Remove **kwargs Nov 3, 2016
@coveralls
Copy link

coveralls commented Nov 3, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 98.81% when pulling d11e4e7 on glemaitre:remove_kwargs into a1af197 on scikit-learn-contrib:master.
@glemaitre
Copy link
Member Author

glemaitre commented Nov 3, 2016

@chkoar @dvro time for review
@glemaitre
Copy link
Member Author

glemaitre commented Dec 3, 2016

@chkoar I remember that you mentioned to change something. However, I do not find any mark of those reviews?

Do you recall ?
@chkoar
Copy link
Member

chkoar commented Dec 3, 2016 •
edited
Loading

Nope. I think that I was skeptic about the many Nones in the init. Since we have documented the defaults I think that we are ok and and open!

So, if you are done we can merge.
@glemaitre
Copy link
Member Author

glemaitre commented Dec 3, 2016

Yep this is fine with me. I let you for the merging
@chkoar chkoar merged commit 62f6d2f into scikit-learn-contrib:master Dec 3, 2016
christophe-rannou pushed a commit to christophe-rannou/imbalanced-learn that referenced this pull request Apr 3, 2017
@glemaitre @chkoar
ENH: Remove **kwargs from some samplers (scikit-learn-contrib#190)
2b43d56
glemaitre added a commit to glemaitre/imbalanced-learn that referenced this pull request Jun 15, 2017
@glemaitre @chkoar
ENH: Remove **kwargs from some samplers (scikit-learn-contrib#190)
cecaac3
glemaitre added a commit to glemaitre/imbalanced-learn that referenced this pull request Jun 15, 2017
@glemaitre @chkoar
ENH: Remove **kwargs from some samplers (scikit-learn-contrib#190)
b94d7a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@glemaitre @coveralls @chkoar