Skip to content

[MRG] ENH: Pass a classifier object instead of string #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 6, 2016
Merged

[MRG] ENH: Pass a classifier object instead of string #186

merged 11 commits into from
Nov 6, 2016

Conversation

@glemaitre
Copy link
Member

@glemaitre glemaitre commented Nov 2, 2016

Whenever possible, pass a classifier estimator instead of a string to be more flexible through experiments.
@coveralls
Copy link

coveralls commented Nov 2, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.009%) to 98.786% when pulling fcdbb9c on glemaitre:generic_classifier into 4889c2e on scikit-learn-contrib:master.
@coveralls
Copy link

coveralls commented Nov 2, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 98.639% when pulling 737484f on glemaitre:generic_classifier into a1af197 on scikit-learn-contrib:master.
@glemaitre
Copy link
Member Author

glemaitre commented Nov 2, 2016

address #189 at the same time

@chkoar that's yours
@coveralls
Copy link

coveralls commented Nov 2, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 98.64% when pulling 909ecd5 on glemaitre:generic_classifier into a1af197 on scikit-learn-contrib:master.
@glemaitre glemaitre changed the title [WIP] EHN: Pass a classifier object instead of string [MRG] EHN: Pass a classifier object instead of string Nov 2, 2016
@coveralls
Copy link

coveralls commented Nov 3, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 98.78% when pulling 3594ea5 on glemaitre:generic_classifier into a1af197 on scikit-learn-contrib:master.
@chkoar chkoar changed the title [MRG] EHN: Pass a classifier object instead of string [MRG] ENH: Pass a classifier object instead of string Nov 3, 2016
chkoar
chkoar reviewed Nov 3, 2016
View reviewed changes
imblearn/ensemble/balance_cascade.py Outdated
self.kwargs = kwargs

def _validate_estimator(self):
"""Private function to create the cluster estimator"""
Copy link
Member

@chkoar chkoar Nov 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"""Private function to create the classifier"""
chkoar
chkoar reviewed Nov 3, 2016
View reviewed changes
imblearn/under_sampling/instance_hardness_threshold.py Outdated
self.kwargs = kwargs

def _validate_estimator(self):
"""Private function to create the cluster estimator"""
Copy link
Member

@chkoar chkoar Nov 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here
@coveralls
Copy link

coveralls commented Nov 3, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 98.78% when pulling 6db7abb on glemaitre:generic_classifier into a1af197 on scikit-learn-contrib:master.
@chkoar chkoar merged commit 7a5afeb into scikit-learn-contrib:master Nov 6, 2016
christophe-rannou pushed a commit to christophe-rannou/imbalanced-learn that referenced this pull request Apr 3, 2017
@glemaitre @chkoar
ENH: Pass a classifier object instead of string (scikit-learn-contrib…
2034f17 
…#186)
glemaitre added a commit to glemaitre/imbalanced-learn that referenced this pull request Jun 15, 2017
@glemaitre @chkoar
ENH: Pass a classifier object instead of string (scikit-learn-contrib…
749a947 
…#186)
glemaitre added a commit to glemaitre/imbalanced-learn that referenced this pull request Jun 15, 2017
@glemaitre @chkoar
ENH: Pass a classifier object instead of string (scikit-learn-contrib…
4f81eb4 
…#186)
@glemaitre glemaitre mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@glemaitre @coveralls @chkoar