Add property setters for class HDBSCAN #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Interoperability is definitely worthwhile. Thanks for this. |
Contributor Author
| @lmcinnes could you please cut a release with this feature commit included? |
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Oct 17, 2024
Until now, we supported all combinations of GPU/CPU interoperability except the one mentioned in the title. This was because the CPU HDBSCAN package was missing attribute setters. With scikit-learn-contrib/hdbscan#657, attribute setters are now available which allow us to transfer GPU trained attributes to the CPU model. This feature is available as part of `hdbscan=0.8.39` Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Bradley Dice (https://github.com/bdice) - Dante Gama Dessavre (https://github.com/dantegd) - William Hicks (https://github.com/wphicks) URL: #6108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This will enable interoperability between https://github.com/rapidsai/cuml GPU HDBSCAN implementation and allow us to transfer properties from the GPU model to the CPU model, letting a user train using GPU and predict using CPU.