Make lazy_load.load partially thread-safe #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@ ## main #90 +/- ## ========================================== + Coverage 93.95% 94.44% +0.48% ========================================== Files 4 5 +1 Lines 182 198 +16 ========================================== + Hits 171 187 +16 Misses 11 11 ☔ View full report in Codecov by Sentry. |
jarrodmillman approved these changes Jan 25, 2024
stefanv force-pushed the thread-safe-load branch from d56c717 to 1b97235 Compare stefanv changed the title lazy_load.load thread-safelazy_load.load partially thread-safe 
| @effigies This may still be worth getting in; it solves the problem when lazy loading, e.g., numpy in parallel. |
effigies approved these changes Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Attempted to close #88, but closed another race condition instead.