Skip to content

Use native endianness for "portable" byte order #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cboulay merged 1 commit into from
May 27, 2023
Merged

Use native endianness for "portable" byte order #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/data_receiver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,8 @@ void data_receiver::data_thread() {
// get the header information
if (type == "byte-order") {
int use_byte_order = std::stoi(rest);
// needed for interoperability with liblsl ~1.13 and data protocol 100
if(use_byte_order == 0) use_byte_order = LSL_BYTE_ORDER;
auto value_size = format_sizes[conn_.type_info().channel_format()];
if (!lsl::can_convert_endian(use_byte_order, value_size))
throw std::runtime_error(
Expand Down