Skip to content

Fix two MSVC warnings #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tstenner merged 3 commits into from
Feb 19, 2022
Merged

Fix two MSVC warnings #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b635cc
Fix MSVC unknown pragma warning
chausner Dec 15, 2021
1068ef1
Fix MSVC implicit conversion warning
chausner Dec 15, 2021
1feb035
Update stream_info_impl.cpp
tstenner Dec 15, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/stream_info_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ uint32_t lsl::stream_info_impl::calc_transport_buf_samples(
else if (nominal_srate() == LSL_IRREGULAR_RATE)
buf_samples = requested_len * 100;
else
buf_samples = nominal_srate() * requested_len;
buf_samples = static_cast<int32_t>(nominal_srate() * requested_len);
if (flags & transp_bufsize_thousandths) buf_samples /= 1000;
buf_samples = (buf_samples > 0) ? buf_samples : 1;
return buf_samples;
Expand Down
3 changes: 2 additions & 1 deletion src/time_postprocessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@
#include <limits>
#include <utility>

#if defined(__GNUC__)
#pragma GCC diagnostic ignored "-Wdouble-promotion"
#ifdef __clang__
#elif defined(__clang__)
#pragma clang diagnostic ignored "-Wimplicit-int-float-conversion"
#endif

Expand Down