Introduce soname to indicate ABI version of shared library #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Having a "soname" that stays constant allows compiled executables that link against liblsl to continue to work whithout recompilation when liblsl is updated as long as the soname of liblsl stays the same. Each time the ABI of liblsl changes in future, the setting LSL_ABI_VERSION in CMakeLists.txt should be incremented by one to change the soname. Closes #140.
Collaborator
| Great, thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Having a "soname" that stays constant allows compiled
executables that link against liblsl to continue to work
whithout recompilation when liblsl is updated as long as
the soname of liblsl stays the same.
Each time the ABI of liblsl changes in future, the setting
LSL_ABI_VERSION in CMakeLists.txt should be incremented by
one to change the soname. Closes #140.