fix(List.Row): filter invalid children in row #5878
Merged
+95 −84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6140cf1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
DorianMaliszewski force-pushed the fix/column-wrongly-sized-offer-list branch from a8e9567 to 6140cf1 Compare 
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@ ## main #5878 +/- ## ========================================== + Coverage 91.75% 92.58% +0.82% ========================================== Files 335 302 -33 Lines 7073 6526 -547 Branches 2734 2549 -185 ========================================== - Hits 6490 6042 -448 + Misses 583 484 -99
... and 33 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
lisalupi approved these changes Dec 11, 2025
philibea approved these changes Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarize concisely:
What is expected?
(Description of the new behavior)
Filter out invalid child as they will not be rendered it caused next cells to get the wrong style (move to the right) because we use
indexto retrieve column styleThe following changes were made:
(Describe what you did)
Filter out bad children in List.Row render
Add a key on column provider
Relevant logs and/or screenshots