Skip to content

fix(instance): replace update commands with generated ones #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Codelax merged 3 commits into from
Dec 14, 2023
Merged

fix(instance): replace update commands with generated ones #3535

Codelax merged 3 commits into from
Dec 14, 2023

Conversation

@Codelax
Copy link
Member

@Codelax Codelax commented Dec 14, 2023

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:
@Codelax Codelax added bug instance Instance issues, bugs and feature requests labels Dec 14, 2023
@Codelax Codelax self-assigned this Dec 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (0c5b66e) 75.71% compared to head (332cf4b) 75.86%.

Files Patch % Lines
internal/namespaces/instance/v1/instance_cli.go 94.59% 14 Missing and 2 partials ⚠️
Additional details and impacted files 
@@ Coverage Diff @@ ## master #3535 +/- ## ========================================== + Coverage 75.71% 75.86% +0.15%  ========================================== Files 178 178 Lines 40452 40527 +75 ========================================== + Hits 30629 30747 +118  + Misses 8716 8672 -44  - Partials 1107 1108 +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
@Codelax Codelax added this pull request to the merge queue Dec 14, 2023
Merged via the queue into scaleway:master with commit 1110cbb Dec 14, 2023
@Codelax Codelax deleted the fix/instance-generated-updates branch December 14, 2023 14:33
Mia-Cross pushed a commit to Mia-Cross/scaleway-cli that referenced this pull request Dec 27, 2023
@Codelax @Mia-Cross
fix(instance): replace update commands with generated ones (scaleway#…
96538d1 
…3535)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug instance Instance issues, bugs and feature requests

3 participants

@Codelax @codecov-commenter @Vinzius