Tracebacks from endpoint failures are propagated to client #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
seanshi-scale commented Jun 28, 2022
launch/client.py Outdated
| resp = self.connection.post( | ||
| payload=payload, | ||
| route=f"{SYNC_TASK_PATH}/{endpoint_id}", | ||
| handle_bad_response=False, |
There was a problem hiding this comment.
if we return http 200 + "failed" as part of the sync endpoint failing response, we can get rid of this "handle_bad_response" thing
seanshi-scale changed the title 
syandroo reviewed Jun 29, 2022
| return EndpointResponse( | ||
| client=self.client, | ||
| status=TASK_SUCCESS_STATE, | ||
| status=raw_response.get("state"), |
There was a problem hiding this comment.
should we consolidate on state vs status haha
There was a problem hiding this comment.
I think we should tbh, I like status personally
yixu34 approved these changes Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add traceback as a field on EndpointResponse for debugging purposes
Also fix unrelated table printing error
see sc-382133 and https://github.com/scaleapi/models/pull/3493
Example invocation:
sync_endpoint.predict(EndpointRequest(**broken_args))which gives an EndpointResponse that looks like