Improved Performance of loadClassesByScalaName #727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution @crt-31 Using the
I also wonder if we could make it even faster using a |
adpi2 approved these changes Jul 8, 2024
| I am going to release this asap. @crt-31 thanks again! Feel free to open new pull requests if you see any other hot spot :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Refactored SourceLookUpProvider.loadClassesByScalaName() to be more efficient.
The issue presented itself in 4.0.0 (related to the HotCodeReplace feature). The debug loading times became really slow.
On my large project, the loading went from 75s back to a normal 12s. (12s is about what I saw in v3.1.6).
This should resolve scalameta/metals#6544