Fix #8729: Drop failing assertion in enter #8815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The eliminated assertion looked weird -- it makes no sense to compare the code (i.e. the bits) of two period encodings. It failed in innocuous code, and dropping it did not cause follow-on errors. Sorry, no test. If someone else wants to add a test, please do. But it is such a weird case (and was such a weird assertion) that I am not sure we need to have a test.
Member
| does #8814 need to merge first? |
Contributor Author
| No, the two are independent. They are both trivial fixes, so we can maybe review and merge them together. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The eliminated assertion looked weird -- it makes no sense to compare
the code (i.e. the bits) of two period encodings. It failed in innocuous
code, and dropping it did not cause follow-on errors.
Sorry, no test. If someone else wants to add a test, please do. But it is
such a weird case (and was such a weird assertion) that I am not sure we need
to have a test.