Add experimental Scala 2 macro compat #8811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nicolasstucki force-pushed the scala2-macro-compat-core branch 5 times, most recently from 216b840 to 4cd0547 Compare nicolasstucki force-pushed the scala2-macro-compat-core branch 2 times, most recently from 7d5b4d9 to 7f5987a Compare 
nicolasstucki commented Apr 28, 2020
| // We do not enter Scala 2 macros defined in Scala 3. | ||
| // Except if they are defined in StringContext to allow the compilation of the stdlib | ||
| // dotty.communitybuild.CommunityBuildTest.stdLib213 | ||
| if (sym.exists && (!sym.isScala2MacroInScala3 || sym.owner == defn.StringContextClass)) { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
odersky requested changes Apr 28, 2020
| // We do not enter Scala 2 macros defined in Scala 3. | ||
| // Except if they are defined in StringContext to allow the compilation of the stdlib | ||
| // dotty.communitybuild.CommunityBuildTest.stdLib213 | ||
| if (sym.exists && (!sym.isScala2MacroInScala3 || sym.owner == defn.StringContextClass)) { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
odersky reviewed Apr 29, 2020
Member
| Ill try this out after scala 2 can read the latest tasty version, should be today or tomorrow |
Contributor Author
| I modified the code of the stdlib to not need the hacky condition in the compiler. Now those macros have their inline counterparts. |
nicolasstucki force-pushed the scala2-macro-compat-core branch 4 times, most recently from c02d798 to e3fbfc4 Compare 
bishabosha requested changes Apr 29, 2020
nicolasstucki force-pushed the scala2-macro-compat-core branch from c19abee to d7adf22 Compare bishabosha reviewed Apr 29, 2020
nicolasstucki force-pushed the scala2-macro-compat-core branch from 2650e19 to 56a38a0 Compare Contributor Author
| Ready for a second review |
bishabosha approved these changes May 7, 2020
Member
bishabosha left a comment
bishabosha left a comment There was a problem hiding this comment.
I was able to use this to link a macro from Scala 2, so LGTM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Minimal version of #8199 aimed to unblock the experimentation of this feature on the Scala 2 TASTy unpickler. This version assumes that the macro is correctly implemented.
Important note: for this feature to work we need to have a version of Scala 2 that can rest TASTy signatures (this is work in progress).