Skip to content

Fix #7529: Don't drop modifiers when desugaring extension methods #7572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2019
Merged

Fix #7529: Don't drop modifiers when desugaring extension methods #7572

merged 1 commit into from
Nov 19, 2019

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Nov 18, 2019

No description provided.

@odersky odersky requested a review from bishabosha November 18, 2019 12:02
bishabosha
bishabosha approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • needs to fix conflicts
@bishabosha bishabosha assigned odersky and unassigned bishabosha Nov 18, 2019
bishabosha
bishabosha requested changes Nov 18, 2019
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will accept once merge conflict is fixed
@bishabosha bishabosha merged commit 5e47774 into scala:master Nov 19, 2019
@bishabosha bishabosha deleted the fix-#7529 branch November 19, 2019 00:18
@bishabosha bishabosha mentioned this pull request Nov 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@odersky @bishabosha