Constant-fold unary operations in Typer #4614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was previously forgotten, even though unary operations such as `!` and `~` were folded later in FirstTransform. As a consequence, inlining simplifications involving constant expressions using these operations were not done. This affected in particular the trace macro, which was always expanded to an operation taking a closure argument.
Contributor Author
| test performance please |
Member
| performance test scheduled: 1 job(s) in queue, 0 running. |
Member
| Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4614/ to see the changes. Benchmarks is based on merging with master (868d199) |
Contributor
| @odersky could you give some example of code that does not get optimized with |
Contributor Author
| @nicolasstucki No application of |
nicolasstucki approved these changes Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This was previously forgotten, even though unary operations such as
!and~were folded laterin FirstTransform. As a consequence, inlining simplifications involving constant expressions
using these operations were not done. This affected in particular the trace macro, which was always
expanded to an operation taking a closure argument.