Attach tailrec annotation #24079
Closed
Attach tailrec annotation #24079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I think the current style is that tailrec annot is noise unless it guards an important degradation. I also think that if the method is "obviously" tailrec, it doesn't need it. What is the case here? What I'd really like is instrumentation to tell me (during tests) that a non-tailrec method is consuming stack. BTW I was a fan of the "tailrec patrol" on Scala 2. |
| I see, I'll close this PR then. Thanks for the review. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Attach tailrec annotation to getAppliedClass