Skip to content

Conversation

@rjolly
Copy link
Contributor

@rjolly rjolly commented Jan 3, 2025

No description provided.

@rjolly rjolly force-pushed the main branch 2 times, most recently from 3a516df to 140ebb6 Compare January 3, 2025 14:40
@rjolly rjolly marked this pull request as draft January 6, 2025 05:11
@rjolly rjolly marked this pull request as ready for review January 6, 2025 11:49
@rjolly rjolly force-pushed the main branch 2 times, most recently from ce82cdf to 6590955 Compare January 6, 2025 17:42
@SethTisue
Copy link
Member

Do you have a link to the PR where you made the needed changes? I'd be interested to see it, just out of curiosity.

@rjolly rjolly marked this pull request as draft January 7, 2025 06:19
@rjolly rjolly marked this pull request as ready for review January 7, 2025 10:36
@rjolly
Copy link
Contributor Author

rjolly commented Jan 7, 2025

@SethTisue Unfortunately, I do not use PRs (yet?). It's essentially in dotty-staging/scas@4ef0d85 . Other than that, the main burden was to change abstract givens to the new deferred mechanism, which is spread over the 8 subsequent commits (you have to look for deferred). Of particular interest is dotty-staging/scas@d22f29b , which introduces a by-name given.

@SethTisue
Copy link
Member

I see this got forgotten about. Once CI likes it, @ me and I'll merge it.

@rjolly
Copy link
Contributor Author

rjolly commented Sep 19, 2025

@SethTisue It is ready, you can go ahead. Many thanks.

@SethTisue SethTisue merged commit 834e8e9 into scala:main Sep 19, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants