[DISC-18903] Remove jquery and hanging javascript assets. #22014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Some notes on files I changed. * `scaladoc/src/dotty/tools/scaladoc/renderers/Resources.scala` This adds jquery to list of resources to load in a scaladoc page. I could remove it after fixing `ux.js`. If you search for jquery now it appears in `dagre-d3.min.js`. But this is only in doc comment examples. * `scaladoc/resources/dotty_res/scripts/ux.js` jQuery powered things like sidebar link behaviour (issuing GET) and item expansion (from mini blurb to full description). * `docs/_spec/public/scripts/toc.js` I tried to do a 1 to 1 port, included bugs like scroll listener being unhooked after clicking a link in the TOC. This table of contents ISN'T the same as what appears in normal docs. This is specific to the language spec. There might be an opportunity here to share code, see IntersectionObserver in `ux.js`. * `docs/_spec/public/scripts/main.js` Nothing exciting here. * `docs/_spec/_layouts/toc.yml` Loads jQuery for previously mentioned language spec TOC. * `docs/_spec/_layouts/default.yml` I think duplicate to above. * `docs/_assets/js/toolbar.js` Lots of unused jquery code. This is hanging source code, with references to code that was removed with commit ... ``` 0f78f73 ``` * `docs/_assets/css/toolbar.css` Same as above. * `docs/_assets/js/sidebar.js` `togglePath` call path removed in same commit above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Some notes on files I changed.
scaladoc/src/dotty/tools/scaladoc/renderers/Resources.scalaThis adds jquery to list of resources to load in a scaladoc page. I could remove it after fixingux.js.If you search for jquery now it appears in
dagre-d3.min.js. But this is only in doc comment examples.scaladoc/resources/dotty_res/scripts/ux.jsjQuery powered things like sidebar link behaviour (issuing GET) and item expansion (from mini blurb to full description).docs/_spec/public/scripts/toc.jsI tried to do a 1 to 1 port, included bugs like scroll listener being unhooked after clicking a link in the TOC. This table of contents ISN'T the same as what appears in normal docs. This is specific to the language spec. There might be an opportunity here to share code, see IntersectionObserver inux.js.docs/_spec/public/scripts/main.jsNothing exciting here.docs/_spec/_layouts/toc.ymlLoads jQuery for previously mentioned language spec TOC.docs/_spec/_layouts/default.ymlI think duplicate to above.docs/_assets/js/toolbar.jsLots of unused jquery code. This is hanging source code, with references to code that was removed with commit ...0f78f739dd31ba095f19d32707315d94469ae9f9docs/_assets/css/toolbar.cssSame as above.docs/_assets/js/sidebar.jstogglePathcall path removed in same commit above.Closes #18903 .