Fix #2072: erasure and refchecks #2085
Conversation
…rarchy. Also, this change postpones generating forwarders for abstract members.
| derivedTree(qual, defn.Any_asInstanceOf, argType) | ||
| } | ||
| | ||
| /** Transform isInstanceOf OrType |
| /** Transform isInstanceOf OrType | ||
| * | ||
| * expr.isInstanceOf[A | B] ~~> expr.isInstanceOf[A] | expr.isInstanceOf[B] | ||
| * expr.isInstanceOf[A & B] ~~> expr.isInstanceOf[A] & expr.isInstanceOf[B] |
There was a problem hiding this comment.
An identical commit has now been merged as part of #2082
| | ||
| val d = member.symbol.copySymDenotation(initFlags = member.symbol.flags.&~(Flags.Deferred)) | ||
| d.installAfter(ctx.erasurePhase.asInstanceOf[Erasure]) | ||
| // Dark magic. Don't look here. |
There was a problem hiding this comment.
This is not a helpful comment. Someone might need to look at this eventually and will be very confused. Also do you need both installAfter and transformAfter ?
There was a problem hiding this comment.
Also do you need both installAfter and transformAfter ?
Yes. The comment here would entirely repeat all the history of transformAfter. I don't think it's worth simplifying it here. To understand why it's needed here one need to read the entire description of 979ee0f which introduces transformAfter
There was a problem hiding this comment.
Then the comment can say "See the commit message of 979ee0f for more information."
2 participants
No description provided.