Adjust the API name entry for nested classes #20279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
eed3si9n force-pushed the wip/canonical_name branch from da05f1f to c5ca07d Compare 
| Thanks for investigating this! I'll review soon |
| Should this be backported to Scala 2? |
| 2.13 bridge should be ok hopefully. As far as I know, the extracted name hasn't changed on Zinc side in a while. |
adpi2 approved these changes May 7, 2024
eed3si9n force-pushed the wip/canonical_name branch from 93db2f2 to 6759a8b Compare 
**Problem** Some build pipelining tests fail on the latest sbt RC. ``` Error: (sbt-test / scripted) Failed tests: Error: pipelining/Yjava-tasty-fromjavaobject Error: pipelining/Yjava-tasty-paths ``` This is likely caused by inconsistent capturing of APIs from Java sources in ExtractAPI vs AnalyzingJavaCompiler in Zinc. **Solution** This adjusts the API name entry for Java nested classes.
eed3si9n force-pushed the wip/canonical_name branch from 6759a8b to accf42d Compare 
WojciechMazur added a commit that referenced this pull request Jul 6, 2024
Backports #20279 to the LTS branch. PR submitted by the release tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Problem
#20157 demonstrated that some build pipelining tests fail on the latest sbt 1.10.0-RC2:
This is likely caused by inconsistent capturing of APIs from Java sources in ExtractAPI vs AnalyzingJavaCompiler in Zinc.
Solution
This adjusts the API name entry for Java nested classes.