Upgrade to Scala.js 1.13.0. #20273
Merged
Upgrade to Scala.js 1.13.0. #20273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Instead of having separate checks for members and classes/modules, we unify them. This gives simpler code and will make it easier to allow nested objects. Additionally: We report a proper error when attempting to export a JS native member (instead of crashing the compiler). Forward port of the upstream commit scala-js/scala-js@14de17d
Forward port of the upstream commit scala-js/scala-js@a8d428e
The `New` is not enough for an `object class Foo$` that is an inner JS object. It needs the correct wrapping generated by `ExplicitJSClasses`. That wrapping exists in the `lazy def` defined in the trait, but cannot be reproduced in the implementing class. In general, we need full paths to do that, which are long gone. When extending a Scala 3-defined trait, we can actually generate a call to the `lazy def`. Although it was never called before (and still is never called for non-JS objects), it was always generated by the Scala 3 compilers. Scala 2, however, does not emit those `lazy def`s. Since I don't see a way out (yet), we report an "Implementation restriction" error in that case.
Code changes are forward ports of the following refactorings: * Split members of ClassDef by type scala-js/scala-js@ec3f406 * Unify TreeHash and Versioned into a single Version scala-js/scala-js@9f5071f * Fix scala-js/scala-js#4769: Give JSPropertyDef a hash scala-js/scala-js@c2bf430
bishabosha approved these changes Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We are several versions behind. Here is a first step.
The commit messages mention the upstream commits that were forward ported.
Tests come for free in the "Upgrade to Scala.js 1.13.0." commit.