Fix #2009: Fix placeholder params logic for lambdas #2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Logic was missing placeholders in rhs of lambdas.
smarter reviewed Feb 22, 2017
| if (in.token == ARROW) { | ||
| placeholderParams = saved | ||
| closureRest(start, location, convertToParams(t)) | ||
| placeholderParams = Nil |
Member
There was a problem hiding this comment.
I don't understand why it's okay to forget the value of placeholderParams here, could you maybe add a comment clarifying this?
smarter approved these changes Feb 22, 2017
Member
smarter left a comment
smarter left a comment There was a problem hiding this comment.
Otherwise LGTM, thanks for the additional comment!
| if (in.token == ARROW) { | ||
| placeholderParams = saved | ||
| closureRest(start, location, convertToParams(t)) | ||
| placeholderParams = Nil // don't interprete `_' to the left of `=>` as a placeholder |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Logic was missing placeholders in rhs of lambdas.