Skip to content

Add -experimental compiler flags #18571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

Add -experimental compiler flags #18571

merged 1 commit into from
Nov 14, 2023

Conversation

@nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Sep 19, 2023 •
edited
Loading

When enabled, all top-level definitions are annotated as @experimental.
This implies that all experimental language features and definitions can
be used in this project.

Note that this does not change the strong guarantees on stability of
non-experimental code. The experimental features can only be used in a
experimental scope (transitively).

This flags does not affect the use of ResearchPlugin.

Follow up of https://contributors.scala-lang.org/t/behaviour-of-experimental-in-scala-3/6309/27?u=nicolasstucki
@nicolasstucki nicolasstucki added the needs-minor-release This PR cannot be merged until the next minor release label Sep 19, 2023
@nicolasstucki nicolasstucki self-assigned this Sep 19, 2023
@nicolasstucki nicolasstucki force-pushed the add-experimental-compiler-flag branch from 8719eaf to 90c9489 Compare September 19, 2023 11:27
nicolasstucki
nicolasstucki commented Sep 19, 2023
View reviewed changes
tests/pos/expeimental-flag.scala
@@ -0,0 +1,18 @@
//> using options -experimental -Yno-experimental
Copy link
Contributor Author

@nicolasstucki nicolasstucki Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Yno-experimental is set to disable experimental features on this snapshot. -experimental is set to add @experimental to the top-level definitions.
@nicolasstucki nicolasstucki force-pushed the add-experimental-compiler-flag branch from 90c9489 to 025c211 Compare September 19, 2023 13:44
@nicolasstucki nicolasstucki marked this pull request as ready for review September 21, 2023 09:20
@nicolasstucki nicolasstucki mentioned this pull request Sep 21, 2023
Closed
@nicolasstucki nicolasstucki force-pushed the add-experimental-compiler-flag branch from 025c211 to 24f4fae Compare September 21, 2023 15:19
@nicolasstucki nicolasstucki added this to the 3.4.0 milestone Sep 21, 2023
@nicolasstucki nicolasstucki added the release-notes Should be mentioned in the release notes label Sep 21, 2023
odersky
odersky requested changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM
@odersky odersky assigned nicolasstucki and unassigned odersky Oct 1, 2023
@nicolasstucki
Add -experimental compiler flags
69cc0ee 
When enabled, all top-level definitions are annotated as `@experimental`. This implies that all experimental language features and definitions can be used in this project. Note that this does not change the strong guarantees on stability of non-experimental code. The experimental features can only be used in a experimental scope (transitively). This flags does not affect the use of `ResearchPlugin`.
@nicolasstucki nicolasstucki force-pushed the add-experimental-compiler-flag branch from 24f4fae to 69cc0ee Compare October 12, 2023 07:55
@nicolasstucki nicolasstucki requested a review from odersky October 12, 2023 13:04
odersky
odersky approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now.

Should this go into the tasty attribute that contains already the other tags instead of being a separate annotation? If yes, that could be done in a follow-on PR.
@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Nov 14, 2023

Should this go into the tasty attribute that contains already the other tags instead of being a separate annotation? If yes, that could be done in a follow-on PR.

Technically it could work. Not sure if it would be benefitial.
@nicolasstucki nicolasstucki merged commit 9136582 into scala:main Nov 14, 2023
@nicolasstucki nicolasstucki deleted the add-experimental-compiler-flag branch November 14, 2023 08:45
@lrytz lrytz mentioned this pull request Feb 16, 2024
Closed
@xuwei-k xuwei-k mentioned this pull request Oct 17, 2024
Merged
@joroKr21
Copy link
Member

joroKr21 commented Dec 22, 2024

Could this be backported to LTS 3.3?
@visma-alexander-maslov
Copy link

visma-alexander-maslov commented Jan 13, 2025

Backporting it to LTS would really be nice. For example there is no more way to use scalamock 7.x for the project depending on the LTS scala :(
scalamock/scalamock#567 (comment)
@prolativ
Copy link
Contributor

prolativ commented Jan 14, 2025

After some discussions within the compiler team it was decided that this should not be backported to 3.3 LTS, which focuses on stability rather than using experimental features
@goshacodes goshacodes mentioned this pull request Jan 15, 2025
Closed
hamzaremmal added a commit that referenced this pull request Feb 26, 2025
@hamzaremmal
Update compiler-plugins.md (#21796)
399d008 
can't enable `ResearchPlugin` if add `-experimental` option. - partially revert #18571 - see also #19841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-minor-release This PR cannot be merged until the next minor release release-notes Should be mentioned in the release notes

5 participants

@nicolasstucki @joroKr21 @visma-alexander-maslov @prolativ @odersky