Fix macro dependency tracking for this #18452
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
smarter requested changes Aug 24, 2023
| * This corresponds to the symbols that will need to be interpreted. | ||
| */ | ||
| private def macroDependencies(tree: Tree)(using Context) = | ||
| val typeAccumulator = new TypeAccumulator[List[Symbol]] { |
There was a problem hiding this comment.
It's hard to figure out if this is good enough because it's hard to know which trees are valid here. I think it'd be much clearer if we combined this logic and the checks from checkIfValidStaticCall in the same traversal, so we'd know exactly which tree shape we need to handle.
By the way, checkIfValidStaticCall is flawed because of local imports:
object Inline extends Macro { val x: Macro = ??? import x._ inline def callMacro(): Int = ${ impl() } }
The symbols of trees do not have enough information to determine the full dependencies. For example, if we have an `Ident` we need to look at its type to figure out which is the `this` prefix on which it is defined. Fix scala#18434
nicolasstucki force-pushed the fix-18434 branch from e14979d to 71f9a9f Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The symbols of trees do not have enough information to determine the full dependencies. For example, if we have an
Identwe need to look at its type to figure out which is thethisprefix on which it is defined.Fix #18434