Skip to content

Conversation

@nicolasstucki
Copy link
Contributor

This provides variant to defn.FunctionOf that only deals with proper FunctionN and ContextFunctionN types. This avoids some overhead. A difference between the two unapplys is that this one does not dealias the type, it needs to be dealiased at call site.

Part of #18305

@nicolasstucki nicolasstucki requested a review from smarter August 17, 2023 18:57
@nicolasstucki nicolasstucki marked this pull request as ready for review August 17, 2023 18:57
This provides variant to `defn.FunctionOf` that only deals with proper `FunctionN` and `ContextFunctionN` types. This avoids some overhead. A difference between the two `unapply`s is that this one does not dealias the type, it needs to be dealiased at call site. Part of scala#18305
@nicolasstucki nicolasstucki assigned odersky and unassigned smarter Aug 30, 2023
@nicolasstucki nicolasstucki requested review from odersky and removed request for smarter August 30, 2023 14:14
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in #18486, I did not understand why the extractor drops a dealias.

Otherwise LGTM

@odersky odersky assigned nicolasstucki and unassigned odersky Oct 1, 2023
@nicolasstucki
Copy link
Contributor Author

As in #18486, I did not understand why the extractor drops a dealias.

See #18486 (comment)

@nicolasstucki nicolasstucki merged commit e4ba788 into scala:main Nov 14, 2023
@nicolasstucki nicolasstucki deleted the add-defn.FunctionNOf branch November 14, 2023 09:01
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
WojciechMazur added a commit that referenced this pull request Jun 26, 2024
Backports #18418 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants