Support polymorphic functions with erased parameters #18293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nicolasstucki force-pushed the poly-erased-functions branch 2 times, most recently from 11c0956 to 2fb1d1f Compare 
smarter approved these changes Jul 26, 2023
There was a problem hiding this comment.
LGTM, I think we should also eventually drop ErasedFunction and only use PolyFunction for all refinements. /cc @natsukagami
| One extra thing you might want to test is subtyping between lambda types, I assume |
This adds support for ```scala [T1, ..., Tn] => ([erased] x1: X1, ..., [erased] xm: Xm) => R ``` Polymorphic function types with erased parameters are represented as using a refinement on `PolyFunction`. `ErasedFunction` is not needed. ```scala PolyFunction { def apply[T1, ..., Tn]([erased] x1: X1, ..., [erased] xm: Xm): R } ``` nicolasstucki force-pushed the poly-erased-functions branch from 2fb1d1f to 5625107 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This adds support for
Polymorphic function types with erased parameters are represented as using a refinement on
PolyFunction.ErasedFunctionis not needed.