WIP: Add package recognition when searching. #18278
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Dedelweiss force-pushed the 17957-search-bar-package branch 4 times, most recently from 1efe7d9 to b896e73 Compare Dedelweiss force-pushed the 17957-search-bar-package branch from b896e73 to 389af75 Compare Dedelweiss changed the title 
Florian3k requested changes Aug 3, 2023
There was a problem hiding this comment.
This doesn't fix #18028 - searching for immutable.BitSet yields no results - we might want to do some kind of partial match
Also, sometimes the highlighted letters look a little weird:
Is it possible to improve that?
cc @szymon-rd, he might have some insight on this
Hi Florian. Of course, thank you very much for the feedback, I'm going to set the PR to "WIP" and improve it! |
Dedelweiss changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In this pull request (PR), the aim was to improve the search functionality by introducing packet recognition. To achieve this, I take the package of the member in the
page.descriptionvalue.I added a search.contains(".") to avoid problems with the abbreviations.
I have just one thing to correct and I also need some opinions about it. The search bar currently only displays the requested package. However, my new search bar displays all the different classes contained in the package. Is this an interesting feature or do you just want to see the package?
So if I keep this result, I should correct the fact that I see the package first and then the different classes underneath for greater logic.
Result:
Fixes: #18028
Fixes: #17957