Fix: Style for wiki syntax #18079
Merged
Fix: Style for wiki syntax #18079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The goal of this PR is to correct the style for wiki syntax when the -comment-syntax:wiki is activate. I have 2 possibilities: First-Change the tag(Done on this PR): So when the correct syntax is called I change the tag to strong,em,etc.. instead of using a span with a class. Second-Change the CSS: We keep the span with a class and we add the correct CSS associated to the class.
bishabosha approved these changes Jun 28, 2023
| awesome, thanks! |
Kordyjan added a commit that referenced this pull request Dec 8, 2023
Backports #18079 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to correct the style of wiki syntax when the -comment-syntax:wiki option is enabled. There are 2 possibilities:
Code:
Before:
After:
Fix: #18051