Refactor: Redirection to boundary/break instead of scala.util.control.NonLocalReturns #17583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bishabosha reviewed May 25, 2023
| Sorry for the confusion but this is not the right file to edit :) You should edit the one that is in |
bishabosha requested changes May 25, 2023
Dedelweiss force-pushed the 17572-boundary-doc branch 2 times, most recently from a541ae0 to 7bdd5c7 Compare 
Dedelweiss force-pushed the 17572-boundary-doc branch from 7bdd5c7 to 3502cef Compare 
| Is it good? Sorry for the confusion about the file and thanks for the feedback. |
bishabosha approved these changes May 25, 2023
| Thank you for making the changes! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes: #17572