Fix aliased type support in ImplicitRunInfo #17471
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
odersky requested changes May 12, 2023
Contributor
odersky left a comment
odersky left a comment There was a problem hiding this comment.
The current fix like a patch for a problem introduced elsewhere. I think we need to focus on wildApprox instead.
| else | ||
| partSeen += t | ||
| t.dealias match | ||
| case dealias if t ne dealias => |
Contributor
There was a problem hiding this comment.
I don't see any motivation for this code, and without it the change seems unsystematic. There is no wildApprox anywhere else in this function. Why introduce it here?
Contributor Author
There was a problem hiding this comment.
I have no idea how to find a better way to put this check. The only thing I've discovered is that this type is not going through wildApprox when I guess it should.
I'll close this MR then.
Contributor Author
| bee299e - reverting this also seems to work ... |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #17305