Implement JSR-45 for Scala 3 #17055
Draft
Implement JSR-45 for Scala 3 #17055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
| Just tying these all together. Refs #9715. |
julienrf force-pushed the jsr45 branch 2 times, most recently from b867bc5 to dcbdedf Compare 
also removes code that was relocationg inlined calls but now is unreachable
Fixes SMAP generation breaking bytecode idempotency assertions
Such warnings are produced when compiling the bootstrapped compiler.
We follow the Kotlin solution to allow inlined code to point to virtual numbers. We rely on the tooling for proper navigation. See also: https://youtrack.jetbrains.com/issue/KT-8628 https://bugs.openjdk.org/browse/JDK-4972961
When emitting the bytecode, line numbers are emitted for trees. These line numbers are used in call stack frames. Trees inlined from other files get virtual numbers. It appears that, when inlining `call(x)`, the line number for `call` is emitted before that for `x`. So, if `x` is coming from the current file, its line number will be real and will override that of `call`.
This reverts commit c07bbbd.
… transform an inlined node
Tetchki added a commit to Tetchki/dotty that referenced this pull request Jul 17, 2023
Refactoring of inlined nodes to simplify the work on scala#17055. This work is based on scala#18229.
Tetchki added a commit to Tetchki/dotty that referenced this pull request Jul 17, 2023
Refactoring of inlined nodes to simplify the work on scala#17055. This work is based on scala#18229.
Tetchki added a commit to Tetchki/dotty that referenced this pull request Jul 17, 2023
Refactoring of inlined nodes to simplify the work on scala#17055. This work is based on scala#18229.
nicolasstucki added a commit that referenced this pull request Jul 27, 2023
Check if the copied inlined node's expansion exists, and if not set it to the original node's expansion. This commit was exctracted from #17055. This simplifies the next step that refactors inlined nodes to keep them until the backend phase.
| curious whether this is still moving forward, here or elsewhere...? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Rebase of #15684 to the latest main. This is a work in progress for a Bachelor Semester Project. For more context see scalacenter/student-projects#8