Respect cacheResult flag in safe initialization cache. #16905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| RE: Signed the Scala CLA. |
olhotak reviewed Mar 3, 2023
| case Cold => Cold | ||
| | ||
| case ref: Ref => eval(vdef.rhs, ref, enclosingClass) | ||
| case ref: Ref => eval(vdef.rhs, ref, enclosingClass, cacheResult = true) |
There was a problem hiding this comment.
Please add test cases that motivated the two changes in Semantic.scala.
olhotak approved these changes Mar 13, 2023
liufengyun reviewed Mar 13, 2023
| val res = { | ||
| given Trace = Trace.empty | ||
| eval(body, thisV, klass) | ||
| eval(body, thisV, klass, cacheResult = true) |
There was a problem hiding this comment.
BTW, it seems we miss a test for this one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The safe initialization checker only needs to cache entries on certain
cachedEvalcalls, specified by acacheResultflag. This PR reduces the size of the safe initialization cache during compilation with-Ysafe-initby respecting the value of the flag, and only caching when it is true.