Give GadtConstraint a nicer toText #16085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Instead of showing the underlying constraint info, which just looks bad, takes up lots of space, and shows details that aren't relevant and often includes leaked type constructors, just show the symbols and their full bounds, nice and compact. And do that as a part of toText instead of having a side "debugBoundsDescription" alternative.
Linyxus reviewed Oct 2, 2022
There was a problem hiding this comment.
Nice! GadtConstraint.toText gives us an indeed compact and concise view of the constraints. It is easy-to-read and reduces the noises.
However, hiding the underlying Constraint from the text still loses information about GADT. The internal constraint state of GADT helps us understand the things better. Importantly, the OrderingConstraint representation of GADT shows the ordering between constrained parameters and the concrete type bounds differently. Such information may still be useful when tracing some complicated problems or implementing new features. Therefore, I'd suggest that
we could keep the debugBoundsDescription method for possible future usage (or maybe commenting it out?).
| Sure, no problem. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Instead of showing the underlying constraint info, which just looks bad,
takes up lots of space, and shows details that aren't relevant and often
includes leaked type constructors, just show the symbols and their full
bounds, nice and compact. And do that as a part of toText instead of
having a side "debugBoundsDescription" alternative.