Three capture checking fixes #15070
Merged
Three capture checking fixes #15070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
odersky changed the title 
Checking against capturing the universal capability now works also for inferred types. Also fix breakage from previous rebase
Allow references to local class parameters in capture sets of public members. These would have been classified as escaping private references before.
1. Fix nonDependentResultApprox. The previous code would unncessessarily widen covariant occurrences to `*`. 2. Add handling of cases like SingletonType <:< CapturingType. 3. Propagate element additions in a AvoidMapped variable back to source
odersky added the cc-experiment Avoid the unsoundness in the previously used technique
olhotak reviewed May 3, 2022
There was a problem hiding this comment.
Additional comment: discussion #15059 seems related to this PR (in the sense that this PR fixes the universal check). If it's possible to quickly reach a decision there, an implementation of that decision could be additionally included as part of this PR.
olhotak reviewed May 3, 2022
Co-authored-by: Ondřej Lhoták <olhotak@uwaterloo.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Three capture checking fixes
*.Also:
Fixes #15049
Fixes #15057 (duplicate of #15049)
Fixes #15058