Skip to content

Conversation

@pikinier20
Copy link
Contributor

This PR is a part of the effort to push the language reference documentation to docs.scala-lang.org. I work on it together with @julienrf .

https://docs.google.com/document/d/1wpvyu_4PH-dqqPoFDbfTjW71bCFFFMYEC8ka_zH8zE8/edit?usp=sharing

Comment on lines +23 to +36
- name: Cache Coursier
uses: actions/cache@v1
with:
path: ~/.cache/coursier
key: sbt-coursier-cache

- name: Cache SBT
uses: actions/cache@v1
with:
path: ~/.sbt
key: sbt-${{ hashFiles('**/build.sbt') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think these could and should be replaced with https://github.com/coursier/cache-action?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copy-paste from our CI. Perhaps we can make it better

key: sbt-${{ hashFiles('**/build.sbt') }}

- name: Set up JDK 11
uses: actions/setup-java@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest release is currently 3.x, should we use a more recent one?

@pikinier20 pikinier20 force-pushed the scaladoc/language-reference-workflow branch 3 times, most recently from ec3d161 to 3d9ce97 Compare April 8, 2022 09:19
@pikinier20 pikinier20 marked this pull request as ready for review April 8, 2022 09:20
@pikinier20 pikinier20 force-pushed the scaladoc/language-reference-workflow branch from 3d9ce97 to b332d62 Compare April 8, 2022 09:29
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge it now and try it. Eventually, it would be good to address the pending comments, though.

@pikinier20 pikinier20 merged commit a00877d into scala:main Apr 12, 2022
@pikinier20 pikinier20 deleted the scaladoc/language-reference-workflow branch April 12, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants