Supress safe initialization warning in Run class #14471
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Due to the `this` pointer being passed to `start.setRun` in a function called during initialization, the initialization checker cannot prove that `this` is fully initialized. We would get the following error: ``` [error] -- Error: /*******/dotty/compiler/src/dotty/tools/dotc/Run.scala:84:17 [error] 84 | start.setRun(this) [error] | ^^^^ [error] |Cannot prove that the value is fully initialized. Only initialized values may be used as arguments. Calling trace: [error] | -> val run = new Run(this, initCtx) { [ ReplCompiler.scala:42 ] [error] | -> class Run(comp: Compiler, ictx: Context) extends ImplicitRunInfo with ConstraintRunInfo {iler-b[ Run.scala:38 ] [error] | -> private var myCtx = rootContext(using ictx) [ Run.scala:89 ] [error] | -> val rootCtx = super.rootContext.fresh [ ReplCompiler.scala:62 ] ``` This sets the store after `myCtx` is set in order to address this error. Review by @liufengyun 
liufengyun reviewed Feb 14, 2022
| if ctx.settings.YexplicitNulls.value && !Feature.enabledBySetting(nme.unsafeNulls) then | ||
| start = start.addMode(Mode.SafeNulls) | ||
| ctx.initialize()(using start) // re-initialize the base context with start | ||
| start |
Contributor
There was a problem hiding this comment.
To pursue this approach, the return type needs to be FreshContext.
That would require changing the overriding method as well, which we might want to avoid.
Contributor Author
There was a problem hiding this comment.
Yeah, I tried doing that, but it would require more changes than I wanted to make for this, since the overridden method does not return a FreshContext
Contributor Author
| Closed due to #14465 (comment) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #14465
Due to the
thispointer being passed tostart.setRunin a function called during initialization, the initialization checker cannot prove thatthisis fully initialized.We would get the following error:
This sets the store after
myCtxis set in order to address this error.Review by @liufengyun