Skip to content

Conversation

bishabosha
Copy link
Member

to be merged when 3.1.0 is released

@bishabosha bishabosha added area:tasty-format issues relating to TASTy as a portable standard await-final-release This PR cannot be merged until a final stable release labels Sep 2, 2021
@bishabosha bishabosha requested a review from Kordyjan September 2, 2021 11:12
@dwijnand dwijnand added this to the 3.1.0 milestone Sep 2, 2021
@smarter
Copy link
Member

smarter commented Sep 2, 2021

Scala 3.0.x was tasty 28.0.x, shouldn't Scala 3.1.x be tasty 28.1.x ?

@bishabosha
Copy link
Member Author

bishabosha commented Sep 2, 2021

Scala 3.0.x was tasty 28.0.x, shouldn't Scala 3.1.x be tasty 28.1.x ?

the 3.1.0-RC1 release was accidentally set to 28.2-1, so we had two choices, i guess we just skip a minor version?

@dwijnand
Copy link
Member

dwijnand commented Sep 2, 2021

#13386 bumped 28.1-1 to 28.2-1 instead of 28.1-0 (though now we know that should wait for the final release anyways). TBH this is tricky to get right, so let's detail it well in the release procedure.

@smarter
Copy link
Member

smarter commented Sep 2, 2021

I see, but I wouldn't worry too much about people accidentally using 3.1.0-RC1 and accidentally depending on a 3.2.0 library, they're using an RC so it's on them anyway, so I don't think it's a problem to use 28.1 here and 28.2 in for 3.2

@bishabosha
Copy link
Member Author

master branch has already been set to 28.3-1 by #13451

@smarter
Copy link
Member

smarter commented Sep 2, 2021

Yeah so it'd have to be set to 28.2-1 too, though again not a big deal since it's only about nightlies.

@dwijnand
Copy link
Member

dwijnand commented Sep 2, 2021

I'm with Guillaume on this, btw. Easier to pretend the mistaken use of 28.1-0 never happened, and fix both the release-3.1.0 and master branches. Otherwise the numbers will always be skewed and need explaining, which is annoying and very likely unnecessary.

@bishabosha
Copy link
Member Author

ok so should we patch this branch immediately to maybe 28.1-2 so that it is still experimental if there is an RC2, and then master goes back to 28.2-1?

@dwijnand
Copy link
Member

dwijnand commented Sep 3, 2021

Yes, I'd say so.

@bishabosha bishabosha force-pushed the patch-final-tasty-3.1.0 branch from 98bb905 to f017d5e Compare September 3, 2021 08:09
@bishabosha bishabosha changed the title patch TASTy version to 28.2-0 for 3.1.0 final patch TASTy version to 28.1-0 for 3.1.0 final Sep 3, 2021
@dwijnand dwijnand marked this pull request as draft September 3, 2021 08:32
@dwijnand
Copy link
Member

dwijnand commented Sep 3, 2021

The PR is ready, but just to avoid it being accidentally merged too early.

@bishabosha
Copy link
Member Author

closing as 89ad511 implements the same fix

@bishabosha bishabosha closed this Oct 18, 2021
@bishabosha bishabosha deleted the patch-final-tasty-3.1.0 branch May 8, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tasty-format issues relating to TASTy as a portable standard await-final-release This PR cannot be merged until a final stable release

4 participants