Deskolemise patterns to suppress exhaustivity warnings #13137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Ideally I'd want to not be destructive with this widen, but it seems to already being done on the other side: in `signature` where the components of the unapply result type are obtained the call to: mt.instantiate(scrutineeTp :: Nil).finalResultType removes the more precise `blub.type` that was present in the signature. So now, by widening the pattern the spaces cancel each other out, thus the match is deemed exhaustive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Ideally I'd want to not be destructive with this widen, but it seems to
already being done on the other side: in
signaturewhere thecomponents of the unapply result type are obtained the call to:
removes the more precise
blub.typethat was present in the signature.So now, by widening the pattern the spaces cancel each other out,
thus the match is deemed exhaustive.
Fixes #13110