implement map function for list-encoding test #12864
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Use the same direction when re-typing during refinement
We are throwing away the refined trees, so we should keep the old type variables unchanged.
Outer references cannot be re-typed with the usual typedSelect algorithm. Their types have to be preserved. Test case is pos/i8892.scala.
Prefer old instance over extremal bound Nothing or Any when refining
- that way we avoid an overly long valOrDefDefSig - the method can be reused in RefineTypes
Add refiner tests that exercise the setting
and drop unused hook method
- Fix bug in copy for dependent function types: parent type needs to be changed as well if refinement has changed. - Refine redundant type checking to eliminate false notices.
Support abbreviated capturing annotations
Needed to override capture inference to state that a type does not capture anything.
Make CapturingTypes take sets instead of single references
I don't know how to specify that f is pure in lazyPureMap since A=>B now means {B} A=>B. As a result, I had to make the capture of the result {A, B} rather than just {A}. 
| I think it would be good to rebase on the current add-cc2 branch and try again. |
| Replaced by dotty-staging#21 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is an attempt to implement map for the list in the
list-encodingtest. Currently this crashes the compiler: