Disallow experimental CB projects on release builds #12449
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
griggt reviewed May 12, 2021
anatoliykmetyuk force-pushed the disallow-experimental-cb-projects-on-releases branch from 4e593b6 to ceacb57 Compare 
Previous mechanism for this inferred experimental capabilities from the version of the compiler (SNAPSHOT or NIGHTLY permits experimental). However this doesn't work in practice: the version of the compiler is set by CI to a stable version only when publish task is executed (not when test tasks are executed). If we set the version as stable for community build as well, the community projects will not be able to resolve it as they operate against the locally published snapshot and not the official stable release version. Hence this solution adds another env var specifically to track experimental features allowance.
anatoliykmetyuk force-pushed the disallow-experimental-cb-projects-on-releases branch from ceacb57 to 2e0edfc Compare 
smarter requested changes May 17, 2021
| - name: Disable experimental features on release | ||
| if: "github.event_name == 'push' | ||
| && startsWith(github.event.ref, 'refs/tags/')" | ||
| run: echo "DISALLOW_EXPERIMENTAL_FEATURES=true" >> $GITHUB_ENV |
Member
There was a problem hiding this comment.
Why not set RELEASEBUILD to yes like in publish_release here? That way we're actually testing with the version number we'll be using for publishing, and the existing compilerSupportExperimental flag should work.
Contributor Author
There was a problem hiding this comment.
dottyVersion in Build.scala is set based on RELEASEBUILD. If it is a yes, publishLocal will publish the compiler locally without the -bin-SNAPSHOT prefix, thus breaking the community build. Hence the need for a separate env variable.
Member
There was a problem hiding this comment.
publishLocal will publish the compiler locally without the -bin-SNAPSHOT prefix, thus breaking the community build.
Why does this break the community build?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previous mechanism for this inferred experimental capabilities
from the version of the compiler (SNAPSHOT or NIGHTLY permits
experimental). However this doesn't work in practice:
the version of the compiler is set by CI to a stable version only
when publish task is executed (not when test tasks are executed).
If we set the version as stable for community build as well,
the community projects will not be able to resolve it as they operate
against the locally published snapshot and not the official stable
release version.
Hence this solution adds another env var specifically to track
experimental features allowance.