Change GADT constrainer to consider all parents when upcasting #11447
Conversation
| test performance please |
| performance test scheduled: 1 job(s) in queue, 1 running. |
| Performance test finished successfully: Visit http://dotty-bench.epfl.ch/11447/ to see the changes. Benchmarks is based on merging with master (e504518) |
| Previous commits change the GADT constrainer's behavior by treating the scrutinee type as an and type constituted by all shared base classes in the hierarchy with the pattern type to derive GADT constraints from all possible parents. This avoids considering unrelated candidates, but requires going deep into the inheritance hierarchy. The modification do not seem to greatly deteriorate the performance as seen in the test. Now an alternative implementation that simply uses direct parents of the scrutinee type to construct the and type is applied. This, in essence, delays subtype-checking. Let's see how the performance is influenced. |
| test performance please |
| You'll need to make a PR adding your name to the list in https://github.com/lampepfl/bench/blob/55576c7eb30517b09ad71f677f0cc73374f4f979/bin/process#L22 to be able to run the benchmarks /cc @liufengyun |
| test performance please |
| performance test scheduled: 1 job(s) in queue, 0 running. |
| Performance test finished successfully: Visit http://dotty-bench.epfl.ch/11447/ to see the changes. Benchmarks is based on merging with master (a633e93) |
| The test results in http://dotty-bench.epfl.ch/11447/ seems problematic. The running time for stdlib is zero. |
| test performance please |
| performance test scheduled: 1 job(s) in queue, 1 running. |
| Performance test finished successfully: Visit http://dotty-bench.epfl.ch/11447/ to see the changes. Benchmarks is based on merging with master (9254ef6) |
| test performance please |
| performance test scheduled: 1 job(s) in queue, 0 running. |
| Performance test finished successfully: Visit http://dotty-bench.epfl.ch/11447/ to see the changes. Benchmarks is based on merging with master (9254ef6) |
4 participants
test performance please