Skip to content

Conversation

@smarter
Copy link
Member

@smarter smarter commented Nov 5, 2020

Testing the Scala.js support is a good idea since if we had done it
before we would have caught #10177 sooner.

Testing the Scala.js support is a good idea since if we had done it before we would have caught scala#10177 sooner.
@smarter
Copy link
Member Author

smarter commented Nov 5, 2020

Hmm, of course all the projects which depend on 1.14 need to be upgraded.

@SethTisue
Copy link
Member

Hmm, of course all the projects which depend on 1.14 need to be upgraded

welcome to my world, it only gets worse :-)

@griggt
Copy link
Contributor

griggt commented Nov 6, 2020

When I ran a local community build including scala-parallel-collections this morning, I just modified it to use scalacheck 1.14.1-SNAPSHOT instead of 1.15.0, and it appeared to work ok, so I don't know that upgrading the entire community build to scalacheck 1.15 is a blocker to adding scala-parallel-collections (although the update would be nice for other reasons).

I think in any case scala-parallel-collections needs some logic in its build.sbt to pick up 1.15.0-SNAPSHOT when running inside the community build vs. just 1.15.0 when built standalone (IIRC other projects need do this). Or just a tweaked build.sbt in the fork on dotty-staging used for the community build.

@SethTisue
Copy link
Member

I'm going to try the same upgrade in the Scala 2 community build; perhaps I'll learn something that will be applicable here: scala/community-build#1285

@SethTisue
Copy link
Member

I'm going to try the same upgrade in the Scala 2 community build; perhaps I'll learn something that will be applicable here: scala/community-build#1285

piece o' cake

@anatoliykmetyuk anatoliykmetyuk removed their assignment Nov 19, 2020
@smarter
Copy link
Member Author

smarter commented Nov 25, 2020

Superceded by #10498 which takes care of aligning version numbers.

@smarter smarter closed this Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants