Only compare group ID and artifact ID when looking for JLine JAR #5399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
If the JLine dependency is resolved through Ivy instead of Maven (which can happen with a local proxy setup in sbt that funnels all artifacts through an Ivy repo), the artifact may have a “configuration” set, which prevents a naive comparison of ModuleIDs from finding it.
| For reference: I ran into this because I use coursier (http://get-coursier.io/) for dependency resolution instead of the built in resolver in sbt. |
lrytz approved these changes Sep 16, 2016
| /** Find a specific module's JAR in a classpath, comparing only organization and name */ | ||
| def findJar(files: Seq[Attributed[File]], dep: ModuleID): Option[Attributed[File]] = { | ||
| def extract(m: ModuleID) = (m.organization, m.name) | ||
| files.find(_.get(moduleID.key).map(extract _) == Some(extract(dep))) |
Member
There was a problem hiding this comment.
Some(extract(dep)) could be stored in a local instead of re-creating it over again
Member
| LGTM |
Member
| Comparing ModuleId's with == isn't very reliable. I improved the situation a little for sbt 1.0 https://github.com/sbt/librarymanagement/pull/48/files It was working before this change before because JLine is a java dependency, so is defined with |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If the JLine dependency is resolved through Ivy instead of Maven (which
can happen with a local proxy setup in sbt that funnels all artifacts
through an Ivy repo), the artifact may have a “configuration” set,
which prevents a naive comparison of ModuleIDs from finding it.
@mgttlinger ran into this issue during the Typelevel Workshop at Scala World.