Add MiMa, remove snapshotScalaBinaryVersion #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Modules have to specify the `mimaPreviousVersion` property. MiMa is NOT executed if - the above property is not set - but the module of version mimaPreviousVersion cannot be resolved against the scalaBinaryVersion A warning is issued if MiMa is skipped.
It only has an effect if the Scala version number is exactly 2.11.0-SNAPSHOT. For 2.11.x-SNAPSHOT with x > 0, sbt already sets the scalaBinaryVersion to 2.11. Note that our nightly release builds don't use -SNAPSHOT for the Scala version, but something like 2.12.0-[sha]-nightly.
| LGTM! Very nice. |
| cool! i'll tag this as v1.0.3. |
lrytz added a commit that referenced this pull request Apr 29, 2015
Add MiMa, remove snapshotScalaBinaryVersion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Review by @adriaanm