Skip to content

Doc: Adds Array#includes and Array#slice #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2020
Merged

Doc: Adds Array#includes and Array#slice #532

merged 1 commit into from
Dec 9, 2020

Conversation

@RubenVerg
Copy link
Contributor

JS has an includes method on arrays instead of the deprecated indexOf() === -1, and drop works like slice (theoretically .dropRight(n) == .slice(0, -n))
@RubenVerg
Adds Array#includes and Array#slice
d6f7cb9 
JS has an `includes` method on arrays instead of the deprecated `indexOf() === -1`, and `drop` works like `slice` (theoretically `.dropRight(n)` == `.slice(0, -n)`)
sjrd
sjrd approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I wouldn't say that indexOf is deprecated, but the changes in the comments LGTM.
@sjrd sjrd merged commit 1807422 into scala-js:master Dec 9, 2020
@RubenVerg
Copy link
Contributor Author

RubenVerg commented Dec 9, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@RubenVerg @sjrd