Skip to content

Conversation

ochrons
Copy link
Contributor

@ochrons ochrons commented Nov 27, 2015

Fixes #185

@sjrd
Copy link
Member

sjrd commented Nov 27, 2015

OK but you have to adapt /.htaccess to to set up the appropriate redirects.

@sjrd
Copy link
Member

sjrd commented Nov 27, 2015

Is _includes/css/style.css an accident? What does this do in this PR?

@ochrons
Copy link
Contributor Author

ochrons commented Nov 27, 2015

For some reason Github considers it a binary file, even though it's just a normal CSS file. It may contain some extra \0 characters or something, but it has been like that for awhile.

I'm actually fixing that in my perf opt branch at the moment, with a lot of other changes to the build process.

@sjrd
Copy link
Member

sjrd commented Nov 27, 2015

My question is rather why it appears in this PR. It does not seem like there should be any change to the CSS, should it?

@ochrons
Copy link
Contributor Author

ochrons commented Nov 27, 2015

There was a minor update to the CSS as well, to squeeze the top headings closer to each other so they would fit on a single line in medium size.

@sjrd
Copy link
Member

sjrd commented Nov 27, 2015

LGTM, OK.

sjrd added a commit that referenced this pull request Nov 27, 2015
Separated libraries under a new section in top menu.
@sjrd sjrd merged commit ac0ec44 into scala-js:master Nov 27, 2015
@ochrons ochrons deleted the library-separation branch November 30, 2015 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants