Skip to content

Generic error event for EventSource #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zetashift merged 2 commits into from
Mar 4, 2024
Merged

Generic error event for EventSource #832

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31925f2
Generic error event for EventSource
cornerman Feb 1, 2024
d68dd23
update api-reports
cornerman Feb 1, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Generic error event for EventSource 
According to MDN the error of an EventSource is a generic Event instead of an ErrorEvent: https://developer.mozilla.org/en-US/docs/Web/API/EventSource/error_event
  • Loading branch information
@cornerman
cornerman authored Feb 1, 2024
commit 31925f2245d35ab9cbdf8fc57b98a53cb384ceb0
2 changes: 1 addition & 1 deletion dom/src/main/scala/org/scalajs/dom/EventSource.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class EventSource private[this] extends EventTarget {

var onmessage: js.Function1[MessageEvent, _] = js.native

var onerror: js.Function1[ErrorEvent, _] = js.native
var onerror: js.Function1[Event, _] = js.native

/** The close() method must abort any instances of the fetch algorithm started for this EventSource object, and must
* set the readyState attribute to CLOSED. W3C 2012
Expand Down